Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: only set level if needed #5384

Merged
merged 5 commits into from
Jun 25, 2024
Merged

perf: only set level if needed #5384

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
743c635
perf: only set level if needed
beckermr Jun 21, 2024
3c47d9f
doc: added news
beckermr Jun 21, 2024
870921a
fix: use exact level on logger
beckermr Jun 21, 2024
94ae523
Merge branch 'main' into test-effective-level
beckermr Jun 25, 2024
38cfad1
Update 5384-test-log-level
beckermr Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion conda_build/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1653,7 +1653,8 @@ def get_logger(name, level=logging.INFO, dedupe=True, add_stdout_stderr_handlers
logging.config.dictConfig(config_dict)
level = config_dict.get("loggers", {}).get(name, {}).get("level", level)
log = logging.getLogger(name)
log.setLevel(level)
if log.level != level:
log.setLevel(level)
if dedupe:
beckermr marked this conversation as resolved.
Show resolved Hide resolved
log.addFilter(dedupe_filter)

Expand Down
3 changes: 3 additions & 0 deletions news/5384-test-log-level
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Enhancements

* Reduced performance overheads of logging. (#4384)
beckermr marked this conversation as resolved.
Show resolved Hide resolved
Loading