Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conda index plugin #131

Merged
merged 12 commits into from
Jan 30, 2024
Merged

Add conda index plugin #131

merged 12 commits into from
Jan 30, 2024

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Oct 20, 2023

Description

Fix #81

Note that this has a different CLI than the old "conda-index" command and would generally break conda-index scripts. This uses a click CLI and is more explicit. For example it won't automatically index the current directory if passed no arguments. For that reason we have been recommending python -m conda_index to use the many-times-faster standalone conda-index.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 20, 2023
conda_index/plugin.py Outdated Show resolved Hide resolved
Co-authored-by: Jannis Leidel <jannis@leidel.info>
conda_index/plugin.py Outdated Show resolved Hide resolved
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@dholth
Copy link
Contributor Author

dholth commented Nov 11, 2023

LMK if you have a chance to test this, I'm not sure if it works correctly or not.

Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea!

@dholth
Copy link
Contributor Author

dholth commented Jan 11, 2024

This interacts badly with the click parser inside conda_index

Copy link
Contributor

@kenodegard kenodegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move ahead and simply remove the deprecated conda index subcommand in conda-build 24.1.0.

pyproject.toml Outdated Show resolved Hide resolved
conda_index/plugin.py Outdated Show resolved Hide resolved
@dholth
Copy link
Contributor Author

dholth commented Jan 25, 2024

I tried this command today, and it seemed to work correctly. (Previously there were issues with the subcommand name being interpreted as one of the arguments to the parser).

Co-authored-by: Ken Odegard <kodegard@anaconda.com>
@jezdez jezdez marked this pull request as ready for review January 29, 2024 14:11
@jezdez jezdez changed the title add conda reindex plugin Add conda index plugin Jan 29, 2024
@kenodegard
Copy link
Contributor

kenodegard commented Jan 29, 2024

we should also add conda index to the recipe's test/commands

(edit) that wont not work until we have a conda-build released without the conda index subcommand

(edit 2) 9bb2303 resolves this for us

conda_index/plugin.py Outdated Show resolved Hide resolved
@jezdez jezdez merged commit c66c0ab into main Jan 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Provide a conda subcommand plugin
4 participants