Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum conda version to 23.3.1 #170

Merged
merged 5 commits into from
Mar 31, 2023
Merged

Bump minimum conda version to 23.3.1 #170

merged 5 commits into from
Mar 31, 2023

Conversation

costrouc
Copy link
Contributor

@costrouc costrouc commented Mar 30, 2023 •
edited

Blocker for release.

Description

Due to conda boltons vendoring deprication see
conda/conda#12453. Results in issues with IndexedSet class changing. Also related to PR #112

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@costrouc
Bump minimum conda version to 23.3.0
d54861a 
Due to conda boltons vendoring deprication see
conda/conda#12453. Results in issues with
`IndexedSet` class changing.
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 30, 2023
@jaimergp jaimergp mentioned this pull request Mar 30, 2023
Closed
20 tasks
dholth
dholth reviewed Mar 30, 2023
View reviewed changes
dev/requirements.txt Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@costrouc
Copy link
Contributor Author

costrouc commented Mar 30, 2023 •
edited

@dholth I thought about doing that. The breakage in conda-libmamba-solver <-> conda happened between 23.1.0 and 23.3.0 so I figured this would be a more accurate pin. I'm open to feedback on that though cc @jaimergp

jezdez and others added 3 commits March 30, 2023 18:30
@jezdez @dholth
Update dev/requirements.txt
989827a 
Co-authored-by: Daniel Holth <dholth@anaconda.com>
@jezdez @dholth
Update pyproject.toml
142d9cf 
Co-authored-by: Daniel Holth <dholth@anaconda.com>
@jezdez @dholth
Update recipe/meta.yaml
e6d453c 
Co-authored-by: Daniel Holth <dholth@anaconda.com>
@costrouc costrouc changed the title Bump minimum conda version to 23.3.0 Bump minimum conda version to 23.3.1 Mar 30, 2023
@jezdez jezdez merged commit e3e98c3 into main Mar 31, 2023
70 checks passed
@jezdez jezdez deleted the bump-min-conda-version branch March 31, 2023 07:23
@jaimergp jaimergp added this to the March 2023 release milestone Mar 31, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dholth dholth dholth left review comments

@jezdez jezdez jezdez approved these changes

@jaimergp jaimergp jaimergp approved these changes

Assignees
No one assigned
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
🔎 Review
Archived in project
Milestone
March 2023 release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@costrouc @jezdez @dholth @jaimergp @conda-bot