Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark conda._vendor.boltons for deprecation. #12453

Merged
merged 9 commits into from
Mar 8, 2023
Merged

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Mar 7, 2023

Description

Resolves #12272.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • [ ] Add / update necessary tests?
  • [ ] Add / update outdated documentation?

@jezdez jezdez requested a review from a team as a code owner March 7, 2023 10:14
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 7, 2023
@jezdez jezdez self-assigned this Mar 7, 2023
conda/auxlib/entity.py Outdated Show resolved Hide resolved
conda/_vendor/boltons/__init__.py Outdated Show resolved Hide resolved
@jezdez jezdez requested a review from kenodegard March 8, 2023 10:01
@kenodegard kenodegard changed the title Mark conda._vendor.boltons for deprecation. Mark conda._vendor.boltons for deprecation. Mar 8, 2023
@jaimergp
Copy link
Contributor

jaimergp commented Mar 14, 2023

@conda/conda-core:

Note subdir_data.py is still using the vendored copy:

/opt/conda-src/conda/core/subdir_data.py:23: PendingDeprecationWarning: conda._vendor.boltons is pending deprecation and will be removed in 24.3. Use `boltons` instead.
    from conda._vendor.boltons.setutils import IndexedSet

I added this and another change in #12482 for better backwards compatibility

jaimergp added a commit to conda/conda-libmamba-solver that referenced this pull request Mar 14, 2023
* Test PR on CI status

* Adapt with conda making boltons depreciated

conda/conda#12453

* Instead import IndexedSet from conda to avoid potential mismatch

* Ensure that cache_path_json is str

* use boltons directly

* Adding news for PR

* skip incompatible test

* pre-commit

* amend boltons bounds

* Update news/151-fix-subdirdata-boltons

---------

Co-authored-by: Jaime Rodríguez-Guerra <jaimergp@users.noreply.github.com>
costrouc added a commit to conda/conda-libmamba-solver that referenced this pull request Mar 30, 2023
Due to conda boltons vendoring deprication see
conda/conda#12453. Results in issues with
`IndexedSet` class changing.
jezdez added a commit to conda/conda-libmamba-solver that referenced this pull request Mar 31, 2023
* Bump minimum conda version to 23.3.1

Due to conda boltons vendoring deprication see
conda/conda#12453. Results in issues with
`IndexedSet` class changing.

Co-authored-by: Jannis Leidel <jannis@leidel.info>
Co-authored-by: Daniel Holth <dholth@anaconda.com>
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Mar 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Convert vendored boltons to a dependency
4 participants