Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "experimental" from README.md #189

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Apr 17, 2023

Fixes #188

Description

This is no longer experimental. So drop this caveat from the README.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

This is no longer experimental. So drop this caveat from the README.
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Apr 17, 2023
@@ -9,7 +9,7 @@ The fast mamba solver, now in conda!

## What is this exactly?

conda-libmamba-solver is a new (experimental) solver for the
conda-libmamba-solver is a new solver for the
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped "experimental", but left "new". Idk if we want to drop both. Please let me know what you think :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, this is fine, thank you!

@jakirkham jakirkham mentioned this pull request Apr 17, 2023
@jakirkham
Copy link
Member Author

Looks like the other CI runs need approval

Also not sure what this pre-commit.ci error means:

Insert license in comments...............................................Failed
- hook id: insert-license
- exit code: 1
- files were modified by this hook

@jaimergp
Copy link
Contributor

Looks like the other CI runs need approval

Also not sure what this pre-commit.ci error means:

Insert license in comments...............................................Failed
- hook id: insert-license
- exit code: 1
- files were modified by this hook

This is being handled in #187, no worries.

@jaimergp jaimergp merged commit 011e3f8 into conda:main Apr 18, 2023
19 of 25 checks passed
@jakirkham
Copy link
Member Author

Thank you both! 🙏

@jakirkham jakirkham deleted the drop_exp_docs branch April 18, 2023 15:07
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Apr 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Still experimental?
4 participants