-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop injecting installed channels that do not exist #274
Conversation
Ready for review. Failures are from the new test_prune_* tests, which are dealt with in #270. |
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a new network i/o path into the mix is a little concerning, but we can make it work
*in_state.maybe_free_channel(), | ||
) | ||
] | ||
override = (getattr(context, "_argparse_args", None) or {}).get("override_channels") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if conda
should have a context
flag for override_channels
. This is a bit clunky and, unless I am missing a good reason, unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed
I suspect the reasoning was because it would mean users could set it in their condarc and override channel settings set by sys admins
Ehm, so I moved the tests to a different file and CI workflow to debug things a bit and it passes there. Definitely some kind of side-effect with other test in the upstream suite. Will deselect and we can move on. |
IMO this is good to go |
Description
Closes #262
Checklist - did you ...
news
directory (using the template) for the next release's release notes?