The RE used to split tokens is too narrow

[asterbini]

I noticed that when using conda WITH tokens sometimes the token part is not recognized if it contains also the char '_' (underscore).
This patch enlarge regular expression to split the token to all chars different from '/'

[anaconda-issue-bot]

We require contributors to sign our Contributor License Agreement, and we don't have one on file for @asterbini. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature.

[jezdez]

@anaconda-issue-bot check

[wagnerpeer]

I doubt that the regex [^/] is fully correct, as it would allow URLs/token to contain ? and other special characters.
I haven't found a reference to the parts where token are generated, but I assume that token will always be alphanumeric with dividers of blocks like - and _. Hence, extending the regex to include _ seems like the better option to me.

I am also missing the same changes to conda/conda/gateways/logging.py#L32

[wagnerpeer]

What about similar changes to conda/conda/gateways/logging.py#L32?

[asterbini]

What about similar changes to conda/conda/gateways/logging.py#L32?

Yes, it makes sense. I did not notice that RE, I just was fixing mamba/conda .

[wolfv]

@wagnerpeer the regex you linked has teh same prolbme for the token matching though (r'/t/[a-z0-9A-Z-]+/' # token) as in not matching a token with an underscore.

The problem here is that the first two letters of a token generated by anaconda.org are the first two letters of the username.

Apparently anaconda.org allows underscores in usernames.

So when your username is x_blabla your tokens will look like x_-uuid4123-1231-1231-1321-aaaaaa which breaks these regex's.

[wagnerpeer]

@wagnerpeer the regex you linked has teh same prolbme for the token matching though (r'/t/[a-z0-9A-Z-]+/' # token) as in not matching a token with an underscore.

Correct, that was the intention. Making aware of another location with the same issues.

The problem here is that the first two letters of a token generated by anaconda.org are the first two letters of the username.

Apparently anaconda.org allows underscores in usernames.

So when your username is x_blabla your tokens will look like x_-uuid4123-1231-1231-1321-aaaaaa which breaks these regex's.

That explains the issue, but can you give a reference (documentation) on how a token is defined? Where did you find, that the first two characters are copied from the username?
If the statement holds true, then a solution could look like r'/t/.{2}[a-z0-9A-Z-]+/' # token?

[asterbini]

That explains the issue, but can you give a reference (documentation) on how a token is defined? Where did you find, that the first two characters are copied from the username?
If the statement holds true, then a solution could look like r'/t/.{2}[a-z0-9A-Z-]+/' # token?

I just noticed that my username on anaconda starts with 'a_' and the token start with the same two chars
.{2} seems to me too wide, perhaps [^/]{2} or something even narrower ?