Handle jlap response without request e.g. for file:/// #12994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholth
changed the title
conda-bot
added
the
cla-signed
jezdez
changed the title
jezdez
approved these changes
Aug 22, 2023
| @@ -278,6 +320,8 @@ def test_jlap_sought( | |||
| package_repository_base: Path, | |||
| ): | |||
| """Test that we try to fetch the .jlap file.""" | |||
| (package_repository_base / "osx-64" / "repodata.jlap").unlink(missing_ok=True) | |||
There was a problem hiding this comment.
Is this just a precaution? Or does this point to a larger issue of test cleanup failing elsewhere?
There was a problem hiding this comment.
The test web server thread points to a single directory. We could use other strategies like copying those files into a per-test directory or creating a per-test scoped fixture to cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #12963
Test needs to be updated to point to the same place the test http server is getting its files; do we need to test with and without .jlap on the filesystem; do we work correctly when there is a range request or do we detect that those are unsupported; or should we simply not do the jlap bits when we are not on http or s3.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?