-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock repodata cache by default #12996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezdez
reviewed
Aug 16, 2023
Was hoping to just merge this control with likely future per file package
locks.
…On Wed, Aug 16, 2023, 7:20 PM Jannis Leidel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In conda/cli/conda_argparse.py
<#12996 (comment)>:
> @@ -1845,7 +1845,12 @@ def add_parser_channels(p):
action="append",
choices=["jlap", "lock"],
help="jlap: Download incremental package index data from repodata.jlap; implies 'lock'. "
- "lock: use locking when reading, updating index (repodata.json) cache. ",
+ "lock: use locking when reading, updating index (repodata.json) cache. Now enabled.",
+ )
+ channel_customization_options.add_argument(
+ "--no-lock",
Since this is a lock for the repodata handling, I wonder if something more
specific be more appropriate like
⬇️ Suggested change
- "--no-lock",
+ "--no-lock-repodata",
or
⬇️ Suggested change
- "--no-lock",
+ "--no-repodata-lock",
This might prevent any conflict in case we add other locking in the
future..
—
Reply to this email directly, view it on GitHub
<#12996 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABSZEXA5EUU45MO2QYB3BTXVVITBANCNFSM6AAAAAA3NI2KZY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Ah, gotcha, thanks for elaborating, works for me. |
jezdez
approved these changes
Aug 22, 2023
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO figure out what to do with
--experimental=lock
. The intention would be to keep all--experimental=
options forever to not break configs as unknown ones create errors in the argument parser, but it might not be necessary to retain them in the command line help.Fix #12920
Checklist - did you ...
news
directory (using the template) for the next release's release notes?