23.7.x find commands permission error #13086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2023
Closed
dholth
reviewed
Sep 11, 2023
dholth
previously approved these changes
Sep 11, 2023
conda-bot
added
the
cla-signed
beeankha
approved these changes
Sep 11, 2023
dholth
reviewed
Sep 11, 2023
| try: | ||
| for entry in os.scandir(dir_path): | ||
| m = pat.match(entry.name) | ||
| if m and entry.is_file(): | ||
| res.add(m.group(1)) | ||
| except PermissionError: | ||
| except (FileNotFoundError, PermissionError): |
There was a problem hiding this comment.
A call to os.scandir('conda.py') produces NotADirectoryError which is a subclass of OsError. Should be added to this except: clause.
There was a problem hiding this comment.
I just tested this locally:
$ python -c "import os; os.scandir('yellow')"
Traceback (most recent call last):
File "<string>", line 1, in <module>
FileNotFoundError: [Errno 2] No such file or directory: 'yellow'
There was a problem hiding this comment.
Add an existing file to PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While we check whether a path is a directory we don't also check whether the user has read access resulting in PermissionError if any paths are restricted.
Resolves #13058
Target
23.7.xinstead ofmain, supersedes #13062Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?