Log missing or non-string RepodataState items at debug level instead … #13151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jezdez
approved these changes
Sep 26, 2023
jezdez
changed the title
beeankha
approved these changes
Sep 26, 2023
dholth
commented
Sep 26, 2023
| @@ -468,7 +468,7 @@ def __setitem__(self, key: str, item: Any) -> None: | |||
| if key in self._aliased: | |||
| key = key[1:] # strip underscore | |||
| if key in self._strings and not isinstance(item, str): | |||
| log.warn(f'Replaced non-str RepodataState[{key}] with ""') | |||
| log.debug('Replaced non-str RepodataState[%s] with ""', key) | |||
There was a problem hiding this comment.
This form doesn't perform the substitution unless debug logs are enabled. Not exactly a hot path but why not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…of warning
Description
This can be triggered by the server not returning an Etag header or by another *.info.json-writer (does mamba use the new extension?) for example. Log at debug level.