Remove imports from pip/requests's vendored packages #13171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
kenodegard
changed the title
beeankha
previously approved these changes
Oct 3, 2023
kenodegard
commented
Oct 4, 2023
kenodegard
commented
Oct 4, 2023
beeankha
previously approved these changes
Oct 4, 2023
Requests already depends on charset-normalizer so this is a "cheaper" new dependency.
kenodegard
commented
Oct 11, 2023
beeankha
previously approved these changes
Oct 16, 2023
jezdez
previously approved these changes
Oct 16, 2023
There was a problem hiding this comment.
charset-normalizer is a pretty old version on defaults: https://anaconda.org/main/charset-normalizer
But a recent one on conda-forge: https://anaconda.org/conda-forge/charset-normalizer
Might be useful to review https://github.com/Ousret/charset_normalizer/blob/master/CHANGELOG.md if there are any features or fixes needed.
Otherwise LGTM
dholth
reviewed
Oct 16, 2023
beeankha
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop relying on vendored packages provided by
pipandrequestsand instead depend on the dependency itself.Removes the following fallback imports:
pip._vendor.requestsrequests.packages.chardet(addedcharset-normalizeras dependency)pip._vendor.requests.packages.chardet(addedcharset-normalizeras dependency)Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update necessary tests?Add / update outdated documentation?