Enable performance tracking via continuous benchmarking. #13460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jezdez
changed the title
conda-bot
added
the
cla-signed
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
jezdez
commented
Jan 4, 2024
travishathaway
previously approved these changes
Jan 8, 2024
jaimergp
reviewed
Jan 8, 2024
| @@ -210,11 +214,11 @@ def test_env_remove(conda_cli: CondaCLIFixture, tmp_env: TmpEnvFixture): | |||
| assert not code | |||
|
|
|||
|
|
|||
| @pytest.mark.benchmark | |||
There was a problem hiding this comment.
In the future I'd rather see a tests/benchmarks/ directory with benchmark-focused tests so we don't mix IO too much, since codspeed since to be focusing on CPU bound tasks.
There was a problem hiding this comment.
Yeah, that makes sense, I even started with it at first and then noticed that I was duplicating a lot of efforts. I started from the tests in conda-benchmarks, but thought to first get some experience with codspeed.
jaimergp
previously approved these changes
Jan 8, 2024
kenodegard
requested changes
Jan 8, 2024
Co-authored-by: Ken Odegard <kodegard@anaconda.com>
kenodegard
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This sets up codespeed following their docs: https://docs.codspeed.io/ci/github-actions
I've selected a number of basic tests to run for now, we can tweak that list in the future.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?[ ] Add / update outdated documentation?