Remove unused setuptools remainings #13684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda once was once packaged by setuptools + wheel extension. conda#12509 did the switch to hatch, which has its own wheel builder: https://github.com/pypa/hatch/blob/master/backend/src/hatchling/builders/wheel.py#L160 Thus the wheel package (containing the setuptools wheel extension) and the MANIFEST.in file (describes what setuptools should include) can be removed. The hatch file selection is not based on the MANIFEST.in, see https://hatch.pypa.io/1.9/plugins/builder/wheel/#default-file-selection
conda-bot
added
the
cla-signed
dholth
approved these changes
Mar 12, 2024
CodSpeed Performance ReportMerging #13684 will not alter performanceComparing Summary
|
jezdez
approved these changes
Mar 12, 2024
dholth
pushed a commit
that referenced
this pull request
Mar 20, 2024
jezdez
pushed a commit
to Callek/conda
that referenced
this pull request
Apr 9, 2024
beeankha
added a commit
to beeankha/conda
that referenced
this pull request
May 3, 2024
beeankha
added a commit
to beeankha/conda
that referenced
this pull request
May 3, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conda once was once packaged by setuptools + wheel extension.
#12509 did the switch to hatch, which has its own wheel builder: https://github.com/pypa/hatch/blob/master/backend/src/hatchling/builders/wheel.py#L160
Thus the wheel package (containing the setuptools wheel extension) and the MANIFEST.in file (describes what setuptools should include) can be removed. The hatch file selection is not based on the MANIFEST.in, see https://hatch.pypa.io/1.9/plugins/builder/wheel/#default-file-selection
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?