Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify bash unsupported markers #13738

Merged

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Mar 26, 2024

Description

The skipif markers for whether a bash flavored test_activate.py test can run is overly verbose. This creates reusable markers for easy usage.

before after
@pytest.mark.skipif(
    bash_unsupported(),
    reason=bash_unsupported_because(),
)
def test_foo(...):
    ...
@skip_unsupported_bash
def test_foo(...):
    ...
@pytest.mark.skipif(
    bash_unsupported_win(),
    reason=bash_unsupported_win_because(),
)
def test_bar(...):
    ...
@skip_unsupported_posix_path
def test_bar(...):
    ...

Split from #13620

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Mar 26, 2024
@kenodegard kenodegard force-pushed the simplify-skipif-unsupported-bash branch from 1861844 to 81b9d3c Compare March 26, 2024 21:34
Copy link

codspeed-hq bot commented Mar 26, 2024

CodSpeed Performance Report

Merging #13738 will not alter performance

Comparing kenodegard:simplify-skipif-unsupported-bash (899fefa) with main (11c21d5)

Summary

✅ 21 untouched benchmarks

@kenodegard kenodegard marked this pull request as ready for review March 26, 2024 23:40
@kenodegard kenodegard requested a review from a team as a code owner March 26, 2024 23:40
@travishathaway travishathaway merged commit 6eca45a into conda:main Apr 2, 2024
66 checks passed
@kenodegard kenodegard deleted the simplify-skipif-unsupported-bash branch April 2, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants