Check link 2 #3301
Closed
Check link 2 #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
LGTM, only one potential improvement on plan.py. Using setdefault function may avoid using functions like add_extract_check. |
|
Thanks, much simpler! |
Current coverage is 71.3% (diff: 92.1%)@@ master #3301 diff @@
==========================================
Files 78 78
Lines 9831 9929 +98
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6994 7078 +84
- Misses 2837 2851 +14
Partials 0 0
|
|
superseded by #3571 |
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #3034 "Check link". Modified checks into instructions that are now a part of the operation order.
Possible solution to #1733 by always checking permissions before linking and unlinking.