Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add debug exception for #6430 #6435

Merged
merged 1 commit into from
Dec 13, 2017
Merged

add debug exception for #6430 #6435

merged 1 commit into from
Dec 13, 2017

Conversation

kalefranz
Copy link
Contributor

@kalefranz kalefranz commented Dec 11, 2017

This PR does not close #6430, but it adds an exception with additional information for the next time anybody runs across it.

@kalefranz kalefranz added this to the 4.4.0 milestone Dec 11, 2017
the output of 'conda info' and 'conda list' for the active environment, along
with the command you invoked that resulted in this error.
matches_for_spec: %s
""") % matches_for_spec)
Copy link
Contributor

@goanpeca goanpeca Dec 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @kalefranz, but don't we have almost the exact same text somewhere else? Does it make sense to reuse it instead of rewriting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do, except it's only displayed for exceptions that don't subclass CondaError. This in particular is a CondaError, which means the full stack trace won't be shown (which is what the intention is here).

This exception is also meant to be temporary. It'll be removed as soon as we understand the root cause of the issue.

Note that I pulled #6430 from our auto-reports. There was no user who created an issue for us to interact with.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

Copy link
Contributor

@goanpeca goanpeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have a question

@goanpeca goanpeca merged commit 1241475 into conda:4.4.x Dec 13, 2017
@kalefranz kalefranz deleted the debug-6430 branch December 13, 2017 23:37
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Sep 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants