fix #7341: constrain tell() return value to [0,filesize]

[mbargull]

fix #7341

I think that error being thrown essentially means that a fileobj.tell() (with fileobj being an io.BufferedReader created by open(..., 'rb')) can return negative values!? That's a really strange thing...
I'll submit a PR that constrains the values we use to

0 <= v <= max(1, fstat(fileobj.fileno()).st_size)

[kalefranz]

LGTM. Not sure what the status of tests are in the 4.5.x branch currently. Just coming back from a week of vacation. Might push directly to this branch to clean up test failures if we have any.

[mbargull]

Not sure what the status of tests are in the 4.5.x branch currently.

Haven't been very active myself here lately, so can't tell either.

Just coming back from a week of vacation.

🏖️ 👍

Might push directly to this branch to clean up test failures if we have any.

Yes, feel free to do so!

[kalefranz]

I guess we added gawk to the repo for unix platforms. That's the reason for the current failure. I'll refactor that test.

[mbargull]

Restarted py27 main tests. That one failed with the occasional

___________ ShellWrapperIntegrationTests.test_bash_basic_integration ___________
Traceback (most recent call last):
  File "/home/circleci/conda/tests/test_activate.py", line 1117, in test_bash_basic_integration
    self.basic_posix(shell)
  File "/home/circleci/conda/tests/test_activate.py", line 1092, in basic_posix
    shell.expect('Executing transaction: ...working... done.*\n', timeout=25)
  File "/home/circleci/conda/tests/test_activate.py", line 1034, in expect
    return self.p.expect(pattern, timeout, searchwindowsize, async)
  File "/opt/conda/lib/python2.7/site-packages/pexpect/spawnbase.py", line 327, in expect
    timeout, searchwindowsize, async_)
  File "/opt/conda/lib/python2.7/site-packages/pexpect/spawnbase.py", line 355, in expect_list
    return exp.expect_loop(timeout)
  File "/opt/conda/lib/python2.7/site-packages/pexpect/expect.py", line 106, in expect_loop
    return self.timeout(e)
  File "/opt/conda/lib/python2.7/site-packages/pexpect/expect.py", line 70, in timeout
    raise TIMEOUT(msg)
TIMEOUT: <pexpect.popen_spawn.PopenSpawn object at 0x7fb79aef98d0>
searcher: searcher_re:
    0: re.compile("Executing transaction: ...working... done.*
")

we are getting from time to time.

[kalefranz]

I think that timeout=35 value is already in master. Might as well be in 4.5.x too.

[github-actions]

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.