resolve #7595 implement win 10 long path reg key for conda init #7629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msarahan
force-pushed
the
init_long_paths
branch
from
5b60add
to
dae890c
Compare
kalefranz
reviewed
Aug 7, 2018
conda/core/initialize.py
Outdated
| @@ -1107,6 +1118,29 @@ def init_cmd_exe_registry(target_path, conda_prefix): | |||
| return Result.NO_CHANGE | |||
|
|
|||
|
|
|||
| def init_long_path(target_path): | |||
| win_ver, win_rev = platform.platform().split('-')[1:3] | |||
| # win10, build 14352 was the first preview release that supported this | |||
There was a problem hiding this comment.
I just extracted from another PR and merged into master something that might be cleaner here (the new code was in #7630; you'll need to rebase). For win_rev, I believe you can use context.os_distribution_name_version[1]. I think on older systems, what you have for win_ver might actually be able to be NT, so int('NT') would 💣.
msarahan
force-pushed
the
init_long_paths
branch
from
dae890c
to
45ae856
Compare
msarahan
force-pushed
the
init_long_paths
branch
from
45ae856
to
d791398
Compare
kalefranz
changed the title
|
Hi there, thank you for your contribution to Conda! This pull request has been automatically locked since it has not had recent activity after it was closed. Please open a new issue or pull request if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toward #7595