Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode repodata to utf-8 while caching #7873

Merged
merged 4 commits into from
Dec 28, 2018

Conversation

geremih
Copy link
Contributor

@geremih geremih commented Oct 18, 2018

Encodes cached repodata as UTF-8 to handle unicode characters gracefully.
(for python2)

@geremih geremih requested a review from a team as a code owner October 18, 2018 16:06
@msarahan
Copy link
Contributor

msarahan commented Dec 6, 2018

Could you please refresh this with the latest master code, or alternatively retarget it to the 4.5.x branch? I don't think the test fails are related, but I want to make sure.

@geremih
Copy link
Contributor Author

geremih commented Dec 11, 2018

@msarahan Tests are passing now.

@nehaljwani
Copy link
Contributor

@geremih Could you sign the Conda CLA please?

@msarahan
Copy link
Contributor

He has. We need to process it, but this is OK to go in in the meantime.

@msarahan
Copy link
Contributor

@geremih my apologies it has taken so long to work with the CLA stuff. I have added you, and will now merge this PR. Thanks for your patience.

@msarahan msarahan merged commit caf0809 into conda:master Dec 28, 2018
@github-actions
Copy link

Hi there, thank you for your contribution to Conda!

This pull request has been automatically locked since it has not had recent activity after it was closed.

Please open a new issue or pull request if needed.

@github-actions github-actions bot added the locked [bot] locked due to inactivity label Aug 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked [bot] locked due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants