-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix MatchSpec roundtrip parsing #9980
Conversation
We require contributors to sign our Contributor License Agreement, and we don't have one on file for @wolfv. In order for us to review and merge your code, please e-sign the PDF at https://conda.io/en/latest/contributing.html#conda-contributor-license-agreement. We then need to manually verify your signature. We will ping the bot to refresh the PR status when we have confirmed your signature. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
def test_roundtrip(self): | ||
a = MatchSpec("numpy=*=*bla") | ||
b = MatchSpec(a.__repr__()) | ||
assert (a == b) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it is failing here
@@ -534,6 +537,8 @@ def _parse_version_plus_build(v_plus_b): | |||
('*', '*') | |||
""" | |||
parts = re.search(r'((?:.+?)[^><!,|]?)(?:(?<![=!|,<>~])(?:[ =])([^-=,|<>~]+?))?$', v_plus_b) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flake is complaining about the extra blank here :-(
@wolfv Hey Wolf, I'm not sure if this is current or not, could you let me know if this is still an issue? |
@jezdez yes, this is still an issue, I just checked. Also, there is another issue I've been hitting before in micromamba. When requesting a spec from the command line like so
|
2a5ab5d
to
a9a2f1b
Compare
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
Hi there, thank you for your contribution! This pull request has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs. If you would like this pull request to remain open please:
NOTE: If this pull request was closed prematurely, please leave a comment. Thanks! |
We have an issue in mamba where the MatchSpec looses some information through the representation.
If you parse
libblas=*=*mkl
, the repr of that islibblas=[build=*mkl]
When parsing
libblas=[build=*mkl]
one hits a assert because the version is empty.I believe it would be better to have
libblas=*[build=*mkl]
and I attached a fix for this.