Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some methods return 2xx codes instead of 404 when the task does not exist. #38

Open
JCHacking opened this issue Jan 9, 2024 · 1 comment
Open

Some methods return 2xx codes instead of 404 when the task does not exist. #38

JCHacking opened this issue Jan 9, 2024 · 1 comment

Comments

@JCHacking
Copy link
Contributor

Describe the bug
Some methods return 2xx codes instead of 404 when the task does not exist.
For example
POST /api/tasks/{task_id}/log -> Return 200 when task does not exists
GET /api/tasks/{task_id} -> Return 204 when task does not exists

Details
Conductor version: v3.14.0
Persistence implementation: MySQL

Expected behavior
When a request is made to a resource (e.g. a task) if it does not exist return code 404.
vgopari pushed a commit to vgopari/conductor that referenced this issue Feb 11, 2024
Fix issue conductor-oss#38: Return 404 instead of 2xx codes for metho…
eb4eaea 
…ds handling non-existent tasks
vgopari pushed a commit to vgopari/conductor that referenced this issue Feb 11, 2024
Fix issue conductor-oss#38: Return 404 instead of 2xx codes for metho…
9f25ce6 
…ds handling non-existent tasks
vgopari pushed a commit to vgopari/conductor that referenced this issue Feb 11, 2024
Fix issue conductor-oss#38: Return 404 instead of 2xx codes for metho…
58abdd5 
…ds handling non-existent tasks
vgopari pushed a commit to vgopari/conductor that referenced this issue Feb 15, 2024
Using NotFoundException when entity is not found conductor-oss#38
828bc5a
@vgopari
Copy link

vgopari commented Feb 16, 2024 •
edited

8bf7e90

vgopari pushed a commit to vgopari/conductor that referenced this issue Mar 4, 2024
Fix issue conductor-oss#38 : Return 204 instead of 404 for /poll end…
b47d627 
…points handling non-existent tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JCHacking @vgopari