Using NotFoundException when entity is not found conductor-oss#38

vgopari · Feb 15, 2024 · 828bc5a · 828bc5a
1 parent 58abdd5
commit 828bc5a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/rest/src/main/java/com/netflix/conductor/rest/controllers/TaskResource.java b/rest/src/main/java/com/netflix/conductor/rest/controllers/TaskResource.java
@@ -16,6 +16,7 @@
 import java.util.Map;
 import java.util.Optional;
 
+import com.netflix.conductor.core.exception.NotFoundException;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PathVariable;
@@ -108,7 +109,7 @@ public ResponseEntity<List<TaskExecLog>> getTaskLogs(@PathVariable("taskId") Str
         return Optional.ofNullable(taskService.getTaskLogs(taskId))
                 .filter(logs -> !logs.isEmpty())
                 .map(ResponseEntity::ok)
-                .orElse(ResponseEntity.notFound().build());
+                .orElseThrow(() -> new NotFoundException("Task logs not found for taskId: %s", taskId));
     }
 
     @GetMapping("/{taskId}")