-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basename feature in #3722 doesn't work after "yarn build" #7
Comments
@meggarr, could you check if this is because of https://github.com/Netflix/conductor/pull/3873/files#diff-c868321113245d9cb0c0ed91ae213c8a2b0be4f4ae257aefcef39bee60292c7eL29-R29? @nhandt2021, we have the function |
@haricane8133 No, it's not. That's because, at runtime, there isn't |
@meggarr That's right |
@meggarr, react-scripts uses WebPack internally right? It is strange that it isn't bundling the JSON dependency... @nhandt2021, I see. Maybe we have to change the comment/function name then. |
@meggarr You need to run this command after building: |
@nhandt2021, the regex works at all places except at ![]() |
@nhandt2021 What about docker build, does that work ? |
@haricane8133 doesn't work (for below case), that's why I raised that PR |
Yeah. I just found that too. Looking for a regex that can accommodate this... |
@meggarr It also works for me The below image, system couldn't fetch the API because I built UI image only. But look at the API's path, it's normal. |
@nhandt2021, there are two parts here
So, setting |
Here is a PR with both the changes - #9 @nhandt2021, let us have @meggarr test the changes and then go for merge... |
Can you let me know how to build the docker ? @nhandt2021 . |
@meggarr I followed this instruction: https://github.com/conductor-oss/conductor/tree/main/docker/ui#running-the-conductor-server Could you provide some screenshots or videos for more detail? |
I followed the steps in here :: https://github.com/orkes-io/orkes-conductor-community/blob/main/docker/DockerfileServer . Started the server via docker compose. But, now I have tore down my env. You can give it a try. @nhandt2021 |
@meggarr You'r right. I can't run (UI) with that docker compose 😢 |
Any updates? Just pinging the way to reproduce the error, in case we went off track with trying docker, etc...
Now the PR fixes the regex, and the |
@haricane8133
|
No I haven't. Why is that needed? You just need to try both
(actually considering the bug, one of them should be good enough too) But the testing should cover all scenarios related to the different ways one can have the
I wouldn't consider this as a different case for the testing required for this bug and PR... If the UI codebase isn't idempotent and has different behaviors on NavLink, with DevServer, ProductionBuild and DockerRun, we are having much bigger problems than this issue :) |
@haricane8133 @meggarr @haricane8133 Could you run the index.html directly after building? (I can't even revert the change) |
This would be the same as |
Shall we revert changes if it is still not good ? |
I'd tested after reverting. And it didn't work with the docker compose that you mentioned. |
@nhandt2021, I am not able to follow. What do you mean by the PR unable to run the Did you run any command scripts from You need to either build and serve the static files using any server, or use the in built NodeJS Dev Server.... (By the way, to test the UI, you don't have to run the whole conductor repo. Just focus inside the 'ui' folder) |
@haricane8133 I am not from Orkes, so I cannot decide here. I don't know how to resolve this. Cc @nhandt2021 |
I don't want to modify the Docker file. I'm finding the the root cause of this @haricane8133 about your feature, I believe that doesn't relate with @meggarr issue, because he want to run the whole app via docker containers (https://github.com/orkes-io/orkes-conductor-community/blob/main/docker/DockerfileServer) Btw: Your pr looks good to me. But I prefer using 1 regex instead of using
I think have many people don't care to run UI only. Most of them run the app via Docker.
I know how to run UI only, and having several ways to do that. Look at this, it runs UI as a static page via Nginx. So the problem here is: if we can't run the static page after building so the Docker file either. |
@meggarr, @nhandt2021, I can certainly try running the Docker file and let you know. I will update the thread.
@meggarr, we don't have to use
@nhandt2021, I am still not able to understand what you mean by this. Please be more specific. Did you double click the
@nhandt2021, it doesn't matter for this issue. If the dockerfile isn't working, let us open another issue and solve it there.
@nhandt2021, let us continue the discussion on the PR. As I mentioned in the PR, I feel having two |
@nhandt2021 Is there a direction of this issue ? |
@meggarr As I told you before, I reverted and tried with that docker compose file, but it didn't work too. But you said it worked before, so I was confused. May I have a question: Do you want to use this |
@nhandt2021 I didn't revert, I use the version of 3.15.0, it works well. For the 2nd question - No, I don't use the I think we need a decision here to revert this feature totally, or to keep it in future release. Thanks! |
* Fixes conductor-oss#7, another dormant bug * Review comment - Combine Regexes
* Fixes conductor-oss#7, another dormant bug * Review comment - Combine Regexes
Describe the bug
The feature in #3722 breaks the "NavLink" with "newTab". The package's homepage (aka basename) doesn't work after "yarn build".
This works on v3.15.0 tag, shall we revert ?
@haricane8133
Details
Conductor UI on the latest main.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: