Fixes #7, another dormant bug #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhandt2021
reviewed
Dec 17, 2023
| @@ -26,7 +26,8 @@ export default React.forwardRef((props, ref) => { | |||
| </Link> | |||
| ); | |||
| } else { | |||
| const href = absolutePath ? url.toString() : cleanDuplicateSlash(getBasename() + url.toString()); | |||
| // Note: + '/' + is required here | |||
| const href = absolutePath ? url.toString() : cleanDuplicateSlash(getBasename() + '/' + url.toString()); | |||
There was a problem hiding this comment.
You add 1 more slash then replace it. Does it make sense?
There was a problem hiding this comment.
getBaseName() can return either
/abc/def, or /abc/def/
We would have to cover both scenarios
There was a problem hiding this comment.
Those two options are possible because we leave the work of filling the homepage field, to the user.
The user can enter the homepage url with a trailing slash, or not... It's up to them, and we should make sure things work both way
nhandt2021
reviewed
Dec 17, 2023
v1r3n
approved these changes
Jan 9, 2024
v1r3n
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Initial commit to add bulk workflow deletion * Added an API endpoint for bulk deletion * Add archiveworkflow param * Added bulk delete action to BulkActionModule * Added archive option to bulk delete * Addition of terminateRemove() Functions (#9) * Added an API endpoint for bulk deletion * Fixed WorkflowBulkServiceTest, added test cases for deleteWorkflow an… (#10) * Fixed WorkflowBulkServiceTest, added test cases for deleteWorkflow and terminateRemove, and added WorkflowResourceTest test for single terminateRemove * pass spotlessjava --------- Co-authored-by: JeffP <jeffp@jeffpham.com> --------- Co-authored-by: jeffp1 <jeffp@jeffpham.com> Co-authored-by: Ayush Thengne <ayushthengne@ayushs-macbook-pro.local> Co-authored-by: Jeff P <28172529+JeffP07@users.noreply.github.com> Co-authored-by: Doe1111 <106997600+Doe1111@users.noreply.github.com>
matiasbur
pushed a commit
to preqin/conductor
that referenced
this pull request
May 2, 2024
* Fixes conductor-oss#7, another dormant bug * Review comment - Combine Regexes
matiasbur
pushed a commit
to preqin/conductor
that referenced
this pull request
May 9, 2024
* Fixes conductor-oss#7, another dormant bug * Review comment - Combine Regexes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #7
Alternatives considered
Describe alternative implementation you have considered