Fix for TimeOut issue #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1r3n
reviewed
May 9, 2024
| { | ||
| break; | ||
| } | ||
| break; |
There was a problem hiding this comment.
this effectively removes the while loop right? Or will it still do a retry to refresh the token until the max retry count is exhausted?
There was a problem hiding this comment.
@v1r3n It would retry on a expired token scenario; any other exception would exit to loop
v1r3n
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for Timeout is included in this PR.
The code has been updated to break when an unauthorized status code is received.
Removed workflowexecutor as a mediator for API calls.