Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podvm: upgrade protoc to v3.15.0 #1734

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

lysliu
Copy link
Contributor

@lysliu lysliu commented Mar 11, 2024

fixes: #1733
v3.11.4 is bad for s390x, which put x86 binary in the s390x package
v3.15.0 is the earliest correct version for s390x

v3.11.4 is bad for s390x

Signed-off-by: Yan Song Liu <lysliu@cn.ibm.com>
Copy link
Contributor

@huoqifeng huoqifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liudalibj
Copy link
Member

As govulncheck issue is kwon issue, and we are working on it. To not block others, I will merge this issue now.

@liudalibj liudalibj merged commit b0d1087 into confidential-containers:main Mar 12, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build fedora s390x podvm binaries
3 participants