podvm: use correct PROTOC_ARCH value for s390x #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PROTOC_ARCH should be "s390x" for version v3.15.0 Signed-off-by: Lei Li <genjuro214@gmail.com> Signed-off-by: Lei Li <cdlleili@cn.ibm.com>
|
@lysliu please help to review |
lysliu
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Yes, the download url changed for the protoc, I didn't realize this file need updated
thanks @genjuro214
LGTM
huoqifeng
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's related to PR #1734.
After updating PROTOC version to v3.15.0, still failed to build s390x fedora-binaries-builder image with following error:
https://github.com/protocolbuffers/protobuf/releases/download/v3.15.0/protoc-3.15.0-linux-s390x_64.zip is not a valid url.
The valid url is: https://github.com/protocolbuffers/protobuf/releases/download/v3.15.0/protoc-3.15.0-linux-s390x.zip
So need revise the value of PROTOC_ARCH