Fixed a NameError in AugeasTree#replace_entry #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build failure is new RuboCop complaining, about "Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true." all over the place, related to its dropping support for Ruby 2.2. https://github.com/rubocop-hq/rubocop/blob/c2047b71a68d079533ebe9b3766a5ed80b7f8a42/relnotes/v0.69.0.md#L23 |
|
@mvidner regarding that rubocop rule. There is basically two options:
|
https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/ The reason is that new RuboCop, which we use, also drops it, which affects the default cop config, which we need to adjust to. > The build failure is new RuboCop complaining, about "Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true." all over the place, related to its dropping support for Ruby 2.2. > > https://github.com/rubocop-hq/rubocop/blob/c2047b71a68d079533ebe9b3766a5ed80b7f8a42/relnotes/v0.69.0.md#L23 > https://github.com/rubocop-hq/rubocop/blob/5ffddbb92926122a4f3fc1bf8ae29d5be31d481f/lib/rubocop/cop/style/frozen_string_literal_comment.rb#L42
- it pleases RuboCop - prepares for Ruby 3 - is more efficient
```console $ srb lib/cfa/augeas_parser.rb:327: Method key does not exist on CFA::AugeasTree https://sorbet.org/docs/error-reference#7003 327 | @data.delete_if { |d| d[:key] == key } ^^^ Errors: 1 ``` See also https://sorbet.org/
undefined local variable or method `key' for #<CFA::AugeasTree:0x0000000002005c10>
mvidner
force-pushed
the
nameerror-replaceentry
branch
from
296b5b0
to
ba6b822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this bug with Sorbet static analysis, and it seems none of the library users exercise this unusual code path.
So I am not sure whether to make a Bugzilla entry for this and release it right away. See also #6 "Do not try to merge changes"