Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frozen strings. Drop support for Ruby 2.2 and 2.3; add 2.6. #29

Merged
merged 5 commits into from
Jun 21, 2019
Merged

Frozen strings. Drop support for Ruby 2.2 and 2.3; add 2.6. #29

merged 5 commits into from
Jun 21, 2019

Conversation

mvidner
Copy link
Contributor

@mvidner mvidner commented Jun 11, 2019

This is an "ecosystem maintenance" PR, in that we adapt to the world changing around us:

New RuboCop, which we use, stopped supporting Ruby 2.2, also 2.3 is out of maintenance by now

For the record, SLE 12 has Ruby 2.1, SLE 15 has Ruby 2.5.

@mvidner
Copy link
Contributor Author

mvidner commented Jun 11, 2019

Open question: should we

@coveralls
Copy link

coveralls commented Jun 11, 2019 •
edited
Loading

Coverage Status

Coverage increased (+3.06%) to 96.223% when pulling 79e9b56 on min-ruby-2.4 into b5e62c4 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 93.141% when pulling 2d457bc on min-ruby-2.4 into b5e62c4 on master.

@jreidinger
Copy link
Contributor

I vote for merging it with others and release together.

@mvidner
Call #data only once per BooleanValue#enabled?,#disabled?
b5d1c43
@mvidner
Documented and tested BooleanValue
0002b01
@mvidner
Drop support for Ruby 2.2 and 2.3; add 2.6.
37cfe2b 
https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/

The reason is that new RuboCop, which we use, also drops it,
which affects the default cop config, which we need to adjust to.

> The build failure is new RuboCop complaining, about "Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true." all over the place, related to its dropping support for Ruby 2.2.
>
> https://github.com/rubocop-hq/rubocop/blob/c2047b71a68d079533ebe9b3766a5ed80b7f8a42/relnotes/v0.69.0.md#L23
> https://github.com/rubocop-hq/rubocop/blob/5ffddbb92926122a4f3fc1bf8ae29d5be31d481f/lib/rubocop/cop/style/frozen_string_literal_comment.rb#L42
@mvidner
Rake is useful for development
b4bc057
@mvidner
Use frozen_string_literal: true
79e9b56 
- it pleases RuboCop
- prepares for Ruby 3
- is more efficient
@mvidner mvidner merged commit 79e9b56 into master Jun 21, 2019
@mvidner mvidner deleted the min-ruby-2.4 branch June 21, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvidner @coveralls @jreidinger