Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop settings+style fixes #27

Merged
merged 2 commits into from Jun 1, 2020
Merged

Rubocop settings+style fixes #27

merged 2 commits into from Jun 1, 2020

Conversation

alagner
Copy link
Contributor

@alagner alagner commented May 31, 2020

Not sure if this what you actually would like to merge, but seems the CIs are failing to due to tool config. This was fixed+some style issues reported by it were addressed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9a66629 on alagner:rubocop_settings into 702fa00 on config-files-api:master.

@alagner alagner mentioned this pull request May 31, 2020
Merged
jreidinger
jreidinger approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for change. This gem tries to follow always the latest rubocop, so it needs sometime adjustment.

@jreidinger jreidinger merged commit 4fd66c6 into config-files-api:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alagner @coveralls @jreidinger