Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop settings+style fixes #27

Merged
merged 2 commits into from Jun 1, 2020
Merged

Rubocop settings+style fixes #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b87eb2c
fix/upgrade rubocop config
alagner May 31, 2020
9a66629
fix formatting according to rubocop warnings
alagner May 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions .rubocop.yml
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ Style/StringLiteralsInInterpolation:
EnforcedStyle: double_quotes

# Is there any justification for "aligned" which is the default?
Style/MultilineOperationIndentation:
Layout/MultilineOperationIndentation:
EnforcedStyle: indented

# https://github.com/SUSE/style-guides/blob/master/Ruby.md#arrays
Expand All @@ -30,16 +30,16 @@ Style/SymbolArray:
# and also colons:
# foo: true
# foo_bar: false
Style/AlignHash:
Layout/HashAlignment:
EnforcedHashRocketStyle: table
EnforcedColonStyle: table

# no extra indentation for multiline function calls
Style/AlignParameters:
Layout/ArgumentAlignment:
EnforcedStyle: with_fixed_indentation

# no extra indentation for case
Style/CaseIndentation:
Layout/CaseIndentation:
EnforcedStyle: end

# "unless" has a different connotation than "if not"
Expand All @@ -55,5 +55,5 @@ Style/RegexpLiteral:
Enabled: false

# Easier recognization if access modified used
Style/AccessModifierIndentation:
Layout/AccessModifierIndentation:
EnforcedStyle: outdent
2 changes: 1 addition & 1 deletion lib/cfa/grub2/default.rb
View file
Open in desktop
Expand Up @@ -101,7 +101,7 @@ def recovery_entry

def cryptodisk
@cryptodisk ||= BooleanValue.new("GRUB_ENABLE_CRYPTODISK", self,
true_value: "y", false_value: "n")
true_value: "y", false_value: "n")
end

VALID_TERMINAL_OPTIONS = [:serial, :console, :gfxterm].freeze
Expand Down
2 changes: 1 addition & 1 deletion lib/cfa/grub2/grub_cfg.rb
View file
Open in desktop
Expand Up @@ -27,7 +27,7 @@ def self.parse(string)

def self.serialize(_string)
raise NotImplementedError,
"Serializing not implemented, use grub2 generator"
"Serializing not implemented, use grub2 generator"
end

def self.empty
Expand Down