Yet another fix for the issue #191. This should be it.

config-i1 · Feb 6, 2022 · 95e1be1 · 95e1be1
1 parent 4c96a50
commit 95e1be1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,8 +1,8 @@
 Package: smooth
 Type: Package
 Title: Forecasting Using State Space Models
-Version: 3.1.6.41003
-Date: 2022-02-01
+Version: 3.1.6.41004
+Date: 2022-02-06
 Authors@R: person("Ivan", "Svetunkov", email = "ivan@svetunkov.ru", role = c("aut", "cre"),
                   comment="Lecturer at Centre for Marketing Analytics and Forecasting, Lancaster University, UK")
 URL: https://github.com/config-i1/smooth

diff --git a/NEWS b/NEWS
@@ -1,4 +1,4 @@
-smooth v3.1.6 (Release data: 2022-02-01)
+smooth v3.1.6 (Release data: 2022-02-06)
 =======
 
 Changes:

diff --git a/src/ssGeneral.cpp b/src/ssGeneral.cpp
@@ -728,7 +728,12 @@ List fitter(arma::mat &matrixVt, arma::mat const &matrixF, arma::rowvec const &r
 
         // This is a failsafe for cases of ridiculously high and ridiculously low values
         if(vecYfit(i-lagsModelMax) > 1e+100){
-            vecYfit(i-lagsModelMax) = vecYfit(i-lagsModelMax-1);
+            if(i-lagsModelMax==0){
+                vecYfit(i-lagsModelMax) = 0;
+            }
+            else{
+                vecYfit(i-lagsModelMax) = vecYfit(i-lagsModelMax-1);
+            }
         }
 
         // If this is zero (intermittent), then set error to zero
@@ -977,7 +982,12 @@ List backfitter(arma::mat &matrixVt, arma::mat const &matrixF, arma::rowvec cons
 
             // This is for cases of ridiculously high and ridiculously low values
             if(vecYfit(i-lagsModelMax) > 1e+100){
-                vecYfit(i-lagsModelMax) = vecYfit(i-lagsModelMax+1);
+                if(i-lagsModelMax==obs+lagsModelMax){
+                    vecYfit(i-lagsModelMax) = 0;
+                }
+                else{
+                    vecYfit(i-lagsModelMax) = vecYfit(i-lagsModelMax-1);
+                }
             }
 
             // If this is zero (intermittent), then set error to zero