Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Improve handling of previous overrides in eval command #313

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

jamesL92
Copy link
Contributor

@jamesL92 jamesL92 commented Nov 19, 2023

  • The PR has a clear title and a concise summary of the changes (Use the present tense and imperative mood for your descriptions)
  • Related issues are linked using Closes #number
  • Code is up-to-date with the main branch
  • There are no linting or formatting errors
  • There are new or updated unit tests validating the change

Going to say this addresses #247 for the python SDK instead of sing a Closes ticket, as there is still work to be done on the Go SDK for this issue.

For Maintainers

Please ensure:

  • The PR is linked to an issue and both are assigned to the same person
  • The PR is labeled as either 'feat', 'bug', or 'chore'
  • The changes have been approved by a reviewer
  • The contributor checklist is fully addressed

@jamesL92
Copy link
Contributor Author

Code here basically mirrors the changes made in #250

@jamesL92 jamesL92 changed the title Python: Improve handling of previous overrides in eval command - python Python: Improve handling of previous overrides in eval command Nov 20, 2023
Copy link
Contributor

@RonConfigu RonConfigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

I will merge it to main but my PR will override some of this code since ConfigSchema has changed.

Thanks @jamesL92

@RonConfigu RonConfigu added the bug Something isn't working label Dec 28, 2023
@RonConfigu RonConfigu merged commit 3ebb70d into configu:main Dec 28, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EvalCommand prioritizes current schema defaults over previous EvalCommand result
2 participants