Add upgrade v3 to update endtime for validator vesting accounts #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 56.88% 56.88%
=======================================
Files 74 74
Lines 5805 5806 +1
=======================================
+ Hits 3302 3303 +1
Misses 2181 2181
Partials 322 322
|
alpe
reviewed
Aug 23, 2022
app/upgrades/v3/upgrades.go
Outdated
| return nil, err | ||
| } | ||
| ak.GetAccount(ctx, accAddr) | ||
| // TODO set endtime for vesting account |
There was a problem hiding this comment.
You would need to cast to *vestingtypes.ContinuousVestingAccount to access the field, apply some safety checks and then update the data via ak.SetAccount
alpe
reviewed
Sep 15, 2022
| newEndTime int64 = 1688220000 | ||
| ) | ||
|
|
||
| var addresses = []string{ |
There was a problem hiding this comment.
These accounts do not exists on mainnet and will break the migration:
tgrade1ukqqgpftlmwf2ylkvfj467e6wynef05lqcrtjn
tgrade19g64psls2eqwd34nu03c2pcc45jptzxpmwmzu9
pinosu
force-pushed
the
420-upgrade_end_time_validators
branch
from
f8b7894
to
dc367e1
Compare
pinosu
added a commit
that referenced
this pull request
Oct 17, 2022
* Add upgrade v3 to update endtime for validator vesting accounts * Add addresses * Add logic for updating end time for vesting account * Migration test example (#454) * Assert end time to be update correctly Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #420