Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental-alter-configs-implementation(KIP-339) #2005

Merged
merged 13 commits into from Jul 11, 2023

Conversation

PrasanthV454
Copy link
Member

No description provided.

Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nitpick comments. Verified locally all the integration tests are passing.

src/Confluent.Kafka/AdminClient.cs Outdated Show resolved Hide resolved
src/Confluent.Kafka/Impl/SafeKafkaHandle.cs Outdated Show resolved Hide resolved
@anchitj
Copy link
Member

anchitj commented Jul 6, 2023

@emasab Thanks for the changes. Should we merge these changes now or wait until we include the librdkafka.redist with KIP-339? My only concern is that integration tests may be blocked until then.

@anchitj anchitj changed the title [WIP] incremental-alter-configs-implementation(KIP-339) Incremental-alter-configs-implementation(KIP-339) Jul 11, 2023
@emasab emasab merged commit 4ff4e29 into master Jul 11, 2023
2 checks passed
@emasab emasab deleted the feature/incremental-alter branch July 11, 2023 11:21
@kmcclellan
Copy link

Hi. Concerning kmcclellan/kafka-di#12, please consider creating new interfaces to introduce new API members (or bumping the major version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants