Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON referenced schema support #2042

Merged
merged 21 commits into from Aug 25, 2023
Merged

JSON referenced schema support #2042

merged 21 commits into from Aug 25, 2023

Conversation

jainruchir
Copy link
Member

No description provided.

examples/JsonWithReferences/JsonWithReferences.csproj Outdated Show resolved Hide resolved
examples/JsonWithReferences/Program.cs Outdated Show resolved Hide resolved
examples/JsonWithReferences/Program.cs Outdated Show resolved Hide resolved
examples/JsonWithReferences/Program.cs Outdated Show resolved Hide resolved
src/Confluent.SchemaRegistry.Serdes.Json/JsonSerializer.cs Outdated Show resolved Hide resolved
@jainruchir jainruchir marked this pull request as ready for review June 9, 2023 11:38
Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Please add a new entry in changelog as well.

@cla-assistant
Copy link

cla-assistant bot commented Aug 7, 2023

CLA assistant check
All committers have signed the CLA.

* Use object mapping when serializing
and deserializing with referenced schemas.

* Test producing and consumer JObject

* Rename JsonSerDesSchemaUtils to JsonSchemaResolver

* Copyright

* Documentation

* Fix unit tests

* Add comment about NJson mapping
@anchitj anchitj merged commit 5d38703 into master Aug 25, 2023
0 of 2 checks passed
@anchitj anchitj deleted the dev_json_references branch August 25, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants