Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.0-RC2 release #2209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

2.4.0-RC2 release #2209

wants to merge 2 commits into from

Conversation

anchitj
Copy link
Member

@anchitj anchitj commented Apr 19, 2024

No description provided.

@anchitj anchitj marked this pull request as ready for review April 19, 2024 03:36
@anchitj anchitj force-pushed the dev_v2.4.0-RC2 branch 3 times, most recently from 252580f to 5976dd5 Compare April 22, 2024 06:05
@emasab
Copy link
Contributor

emasab commented Apr 23, 2024

Thanks Anchit, please add this to CHANGELOG

# 2.4.0

## Enhancements

- References librdkafka.redist 2.4.0. Refer to the [librdkafka v2.4.0 release notes](https://github.com/confluentinc/librdkafka/releases/tag/v2.4.0) for more information.


And change these lines

Install-Package Confluent.Kafka -Version 2.3.0
dotnet add package -v 2.3.0 Confluent.Kafka

@anchitj
Copy link
Member Author

anchitj commented Apr 23, 2024

Thanks Anchit, please add this to CHANGELOG

# 2.4.0

## Enhancements

- References librdkafka.redist 2.4.0. Refer to the [librdkafka v2.4.0 release notes](https://github.com/confluentinc/librdkafka/releases/tag/v2.4.0) for more information.

And change these lines

Install-Package Confluent.Kafka -Version 2.3.0
dotnet add package -v 2.3.0 Confluent.Kafka

I think we should only change the README lines once doing the final release. So that if anyone is following directly the mater README they won't use the RC version.

@emasab
Copy link
Contributor

emasab commented Apr 25, 2024

@anchitj we can keep the CHANGELOG in sync with the code we merge, that is a work in progress too until we release.
They will know it's a RC if they start testing it. Maybe you can change it to
# 2.4.0 (in progress).

About the Install-Package and dotnet add package ok, let's change them with final release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants