Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migarting travis jobs to Semaphore #1503

Merged
merged 62 commits into from
Apr 3, 2023
Merged

Migarting travis jobs to Semaphore #1503

merged 62 commits into from
Apr 3, 2023

Conversation

PrasanthV454
Copy link
Member

@PrasanthV454 PrasanthV454 commented Jan 20, 2023 •
edited
Loading

Migrating current travis jobs to semaphore.

Flake8, docs and integration tests will be executed every time but only on linux x64 machines.

Unit Tests will be executed on all machine types everytime.

@PrasanthV454 PrasanthV454 force-pushed the feature/semaphore-migration branch 2 times, most recently from fc9ec85 to 87b9acb Compare January 24, 2023 10:55
@PrasanthV454 PrasanthV454 changed the title [WIP] Migarting travis jobs to Semaphore Migarting travis jobs to Semaphore Feb 8, 2023
@PrasanthV454 PrasanthV454 marked this pull request as ready for review February 8, 2023 14:30
@PrasanthV454 PrasanthV454 requested a review from a team as a code owner February 8, 2023 14:30
anchitj
anchitj reviewed Feb 9, 2023
View reviewed changes
.semaphore/semaphore.yml Outdated Show resolved Hide resolved
emasab
emasab requested changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems in Linux x64 flake8 is being run on the whole _venv, causing a huge log

@emasab
Copy link
Contributor

emasab commented Feb 15, 2023

Is there a test run for wheel generation?

@PrasanthV454
Copy link
Member Author

PrasanthV454 commented Feb 15, 2023 •
edited
Loading

Is there a test run for wheel generation?
Yes. CIBW_TEST_COMMAND is being set before building the wheels. We can refer to tools/wheels/build-wheels.sh

@PrasanthV454
Copy link
Member Author

PrasanthV454 commented Feb 15, 2023 •
edited
Loading

It seems in Linux x64 flake8 is being run on the whole _venv, causing a huge log

will exclude the venv directory while running flake8

@emasab
Copy link
Contributor

emasab commented Mar 13, 2023

I was checking artifact generation with a test tag and it's failing on windows. It can be that the windows agent has been modified and hasn't got python anymore. @PrasanthV454 please check this.

emasab
emasab approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @PrasanthV454, thanks for the last improvements!

@emasab emasab merged commit 6a78a3a into master Apr 3, 2023
@emasab emasab deleted the feature/semaphore-migration branch April 3, 2023 08:16
emasab pushed a commit that referenced this pull request Jun 19, 2023
@PrasanthV454 @emasab
Migrate Travis jobs to Semaphore (#1503)
5a51904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab approved these changes

@anchitj anchitj anchitj approved these changes

@pranavrth pranavrth Awaiting requested review from pranavrth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrasanthV454 @emasab @anchitj