This repository has been archived by the owner on May 2, 2023. It is now read-only.
Minor improvements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rnpridgeon
commented
Jun 30, 2016
rnpridgeon
commented
- Add repository at base level
- kafka container extends zookeeper (install kafka 1 time)
- Make configure, ensure and launch scripts more generic
TODO: Add unit tests, propose a few changes to base image to take advantage of UNION FS layering
1. Add repository at base level 2. kafka container extends zookeeper (install kafka 1 time) 3. Make configure, ensure and launch scripts more generic
Closed
| echo "===> Printing /etc/${COMPONENT}/${COMPONENT}.properties " | ||
| cat /etc/${COMPONENT}/${COMPONENT}.properties | ||
|
|
||
| echo "===> Launching kafka ... " |
There was a problem hiding this comment.
oops, should be ${COMPONENT}. Good catch
|
|
||
| echo "===> Printing /etc/kafka/server.properties " | ||
| cat /etc/kafka/server.properties | ||
| echo "===> Printing /etc/${COMPONENT}/${COMPONENT}.properties " |
There was a problem hiding this comment.
Jeremy suggested removing this line as this has SSL password and it would be a security bug.
Closed
|
|
||
| echo "===> Launching ${COMPONENT} ... " | ||
| # Don't need exec as the command has it. | ||
| ${COMPONENT}-start /etc/${COMPONENT}/${COMPONENT}.properties |
There was a problem hiding this comment.
still do need to add 'exec' here per @theduderog
There was a problem hiding this comment.
nevermind. I'm going to go ahead and merge this PR and then I'll make this change when I add Schema Registry.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.