support ssh timeout #311
Merged
support ssh timeout #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm merging it into master and will release as part of 0.9.x, so that if it does cause issues (which is unlikely, but still), people can still use 0.8.x branch. |
gousteris
pushed a commit
to gousteris/ducktape
that referenced
this pull request
Aug 30, 2023
gousteris
pushed a commit
to gousteris/ducktape
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to the
connecttimeoutparam (see https://linux.die.net/man/5/ssh_config) in RemoteAccount ssh configuration, and use that value when creating ssh client.Primary use is to speed up our ssh checker test. Mocking ssh client for the checker is possible, but why not expose an extra configuration parameter?
This, however, means that any clusters loaded from json or vagrant will respect connecttimeout parameter, hence I'd like to test it with real jenkins jobs before merging. This is also why I don't want to target 0.7.x with this change, maybe would be a good idea to bump this to 0.9?