Add the possibility to use secure es with basic auth #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 22, 2018 17:32
|
@confluentinc It looks like @elarib just signed our Contributor License Agreement. 👍 Always at your service, clabot |
mwl
reviewed
May 23, 2018
| HttpHost host = new HttpHost(url.getHost(), url.getPort(), url.getProtocol()); | ||
| hostSet.add(host); | ||
| } catch (MalformedURLException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Print exception together with an error message rather than just dumping it?
log.warn("Failed to parse malformed url", e);
|
Would be nice to add support for basic auth to elasticsearch by finishing this PR! (or one of the others) Can we expect it anytime soon? |
|
Sorry, it seems like we've had a number of duplicates. Basic auth has already been merged via #216, so I'm closing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some use cases of secure ES (for example multitenancy), so the Jest client should authenticate.
This PR add the possibility to sink data to a secure ES with basic auth.
✅Code changed & tested
✅Doc changed
FYI : There are many tools used to secure Elasticsearch, for example
xPack https://www.elastic.co/guide/en/x-pack/current/security-getting-started.html
Searchguard https://docs.search-guard.com/latest/index