Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEC-168: Exclude jackson-core from packaging. #305

Merged
merged 2 commits into from
May 3, 2019
Merged

SEC-168: Exclude jackson-core from packaging. #305

merged 2 commits into from
May 3, 2019

Conversation

avocader
Copy link
Contributor

@avocader avocader commented May 3, 2019

ES has a test dependency jackson-core:2.8.1 which has a vulnerability described here - https://nvd.nist.gov/vuln/detail/CVE-2018-19362.
This PR excludes it from packaging.

@avocader avocader requested a review from a team May 3, 2019 00:51
rayokota
rayokota approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avocader
Copy link
Contributor Author

avocader commented May 3, 2019

It happens that connect-runtime was not marked as test scope and it was bringing lots of extra dependencies, including jackson-core. Since the ES test framework dependency appears earlier in the pom - its version was used.

rhauch
rhauch approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@rhauch rhauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @avocader! This is a good find and a better way to fix the problem of too many dependencies getting included.

@rhauch rhauch merged commit 35aa736 into confluentinc:5.2.x May 3, 2019
@rhauch rhauch mentioned this pull request May 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhauch rhauch rhauch approved these changes

@rayokota rayokota rayokota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avocader @rhauch @rayokota