CC-12530: do not throw exception on flush after task close #455
+21
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levzem
force-pushed
the
fix
branch
2 times, most recently
from
a1f29f6
to
ce5e07c
Compare
Signed-off-by: Lev Zemlyanov <lev@confluent.io>
src/main/java/io/confluent/connect/elasticsearch/ElasticsearchSinkTask.java
Outdated
Show resolved
Hide resolved
src/main/java/io/confluent/connect/elasticsearch/ElasticsearchSinkTask.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lev Zemlyanov lev@confluent.io
Problem
the worker calls
SinkTask::closefollowed bySinkTask::flush, butSinkTask::closecloses theBulkProcessorwhich causes the consequent flush to throw an exception.Solution
only flush if the `BulkProcessor is still open
Does this solution apply anywhere else?
If yes, where?
Test Strategy
write a test that flushes after close
Testing done:
Release Plan
backport as far back as possible