Using new config validation #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on apache/kafka#964 |
| } | ||
|
|
||
| // Define Schema configuration group | ||
| static { |
There was a problem hiding this comment.
All these static blocks can be combined.
|
|
||
| @Override | ||
| protected ConfigDef defineConfig() { | ||
| return HdfsSinkConnectorConfig.getConfig(); |
There was a problem hiding this comment.
Are we always going to have a class of AbstractConfig? Should we think about making that the type that's returned rather than ConfigDef. Not really sure which is better, this just looks like in practice it might always be implemented as return SubclassOfAbstractConfig.getConfig();.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.