Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerDialect's upsert query placeholders should be in the order keyCols*, cols* #180

Merged
merged 1 commit into from
Jan 4, 2017
Merged

SqlServerDialect's upsert query placeholders should be in the order keyCols*, cols* #180

merged 1 commit into from
Jan 4, 2017

Conversation

shikhar
Copy link
Contributor

@shikhar shikhar commented Jan 3, 2017

Fixes #179

@shikhar shikhar requested a review from ewencp January 3, 2017 18:39
ewencp
ewencp approved these changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@ewencp ewencp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shikhar shikhar merged commit ecd08d6 into 3.1.x Jan 4, 2017
@shikhar shikhar deleted the gh-179 branch January 4, 2017 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewencp ewencp ewencp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shikhar @ewencp