CC-1878: Allow for case differences while finding missing columns #400
Conversation
|
It looks like @wicknicks hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
wicknicks
force-pushed
the
CC-1878
branch
3 times, most recently
from
65f7f25
to
e063363
Compare
Signed-off-by: Arjun Satish <arjun@confluent.io>
|
It looks like @wicknicks hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
|
|
||
| if (columnNamesLowerCase.size() != dbColumnNames.size()) { | ||
| log.warn("Table has column names which differ only with case sensitivity. Original " | ||
| + "columns={}", dbColumnNames); |
There was a problem hiding this comment.
Perhaps different wording:
Table has column names that differ from field names only by case. Original ...
| @@ -172,6 +172,33 @@ boolean amendIfNecessary( | |||
| missingFields.add(field); | |||
| } | |||
| } | |||
| return missingFields; | |||
|
|
|||
There was a problem hiding this comment.
Maybe return here if missingFields.isEmpty()?
There was a problem hiding this comment.
This list is used to create ALTER table queries. So we need to return the set here.
There was a problem hiding this comment.
Right. If there are no missing fields at this point, why go through the work of checking case-insensitively? Why not return an empty list here?
There was a problem hiding this comment.
ah, missed that. sorry. fixed this.
Signed-off-by: Arjun Satish <arjun@confluent.io>
Signed-off-by: Arjun Satish <arjun@confluent.io>
Signed-off-by: Arjun Satish arjun@confluent.io