CC-8087: Remove plaintext logging of task configs #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[JIRA](https://confluentinc.atlassian.net/browse/CC-8087) These changes remove the logging of task configurations in plaintext, which should be done to avoid leaking database credentials and other secrets. Additionally, the log messages for whether a custom query has been specified by the user are flipped to correctly correspond to the actual presence of a custom query in the connector configuration.
rhauch
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
These changes remove the logging of task configurations in plaintext, which should be done to avoid leaking database credentials and other secrets. Additionally, the log messages for whether a custom query has been specified by the user are flipped to correctly correspond to the actual presence of a custom query in the connector configuration.