Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC-8087: Remove plaintext logging of task configs #791

Merged
merged 2 commits into from Feb 25, 2020
Merged

CC-8087: Remove plaintext logging of task configs #791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2212a92
CC-8087: Remove plaintext logging of task configs
C0urante Feb 25, 2020
770478c
CC-8087: Address checkstyle grievances
C0urante Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/io/confluent/connect/jdbc/JdbcSourceConnector.java
View file
Open in desktop
Expand Up @@ -142,7 +142,7 @@ public List<Map<String, String>> taskConfigs(int maxTasks) {
Map<String, String> taskProps = new HashMap<>(configProperties);
taskProps.put(JdbcSourceTaskConfig.TABLES_CONFIG, "");
taskConfigs = Collections.singletonList(taskProps);
log.trace("Task configs with no query");
log.trace("Producing task configs with custom query");
return taskConfigs;
} else {
List<TableId> currentTables = tableMonitorThread.tables();
Expand All @@ -161,7 +161,10 @@ public List<Map<String, String>> taskConfigs(int maxTasks) {
taskProps.put(JdbcSourceTaskConfig.TABLES_CONFIG, builder.toString());
taskConfigs.add(taskProps);
}
log.trace("Task configs with query: {}, tables: {}", taskConfigs, currentTables.toArray());
log.trace(
"Producing task configs with no custom query for tables: {}",
currentTables.toArray()
);
}
}
return taskConfigs;
Expand Down