Add logging when creating a new RecordWriter #60
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simple logging enhancement that will make it easier to track down the source of things like memory use issues from the logs. |
kkonstantine
approved these changes
Jun 27, 2017
| @@ -349,6 +349,11 @@ private RecordWriter getWriter(SinkRecord record, String encodedPartition) throw | |||
| return writers.get(encodedPartition); | |||
| } | |||
| String commitFilename = getCommitFilename(encodedPartition); | |||
| log.debug( | |||
| "Creating new writer encodedPartition={} filename={}", | |||
There was a problem hiding this comment.
In similar log lines I've found that is useful to enclose the values in single quotes '. Makes reading of such lines easier when the value is empty. Low priority.
ewencp
force-pushed
the
log-record-writer-creation
branch
from
8986332
to
b214dfe
Compare
kkonstantine
pushed a commit
that referenced
this pull request
Jul 20, 2020
CC-7164: Add config to supply raw JSON credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.